Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop node 16 from CI matrix MONGOSH-1898 #2255

Merged
merged 18 commits into from
Dec 17, 2024
Merged

chore: drop node 16 from CI matrix MONGOSH-1898 #2255

merged 18 commits into from
Dec 17, 2024

Conversation

nirinchev
Copy link
Contributor

@nirinchev nirinchev commented Nov 8, 2024

Drops Node 16 from the test matrix.

@addaleax addaleax changed the title chore: Drop node 16 and add node 22 to CI matrix MONGOSH-1898 chore: drop node 16 and add node 22 to CI matrix MONGOSH-1898 Nov 8, 2024
@addaleax
Copy link
Contributor

addaleax commented Nov 8, 2024

cli-repl/package.json uses node >= 16.15.0 - should we bump that as well?

Yeah, if we don't test it, it's probably best to bump it 👍

@nirinchev nirinchev changed the title chore: drop node 16 and add node 22 to CI matrix MONGOSH-1898 chore: drop node 16 from CI matrix MONGOSH-1898 Dec 11, 2024
@nirinchev nirinchev requested a review from addaleax December 16, 2024 19:30
@nirinchev nirinchev marked this pull request as ready for review December 16, 2024 19:30
@nirinchev
Copy link
Contributor Author

@addaleax I've split this PR and only left the changes related to removing Node 16 from the testing matrix. There were still some issues with the Node 22 tests, so I'll investigate those separately.

@nirinchev nirinchev merged commit e8f0450 into main Dec 17, 2024
115 of 119 checks passed
@nirinchev nirinchev deleted the ni/node22 branch December 17, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants