-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop node 16 from CI matrix MONGOSH-1898 #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Nov 8, 2024
addaleax
changed the title
chore: Drop node 16 and add node 22 to CI matrix MONGOSH-1898
chore: drop node 16 and add node 22 to CI matrix MONGOSH-1898
Nov 8, 2024
Yeah, if we don't test it, it's probably best to bump it 👍 |
addaleax
reviewed
Nov 12, 2024
nirinchev
changed the title
chore: drop node 16 and add node 22 to CI matrix MONGOSH-1898
chore: drop node 16 from CI matrix MONGOSH-1898
Dec 11, 2024
@addaleax I've split this PR and only left the changes related to removing Node 16 from the testing matrix. There were still some issues with the Node 22 tests, so I'll investigate those separately. |
addaleax
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops Node 16 from the test matrix.